Skip to content

fix hardcoded postgres user in DB - #691

Open
hmassad wants to merge 1 commit into
Gentleman-Programming:mainfrom
hmassad:patch-1
Open

fix hardcoded postgres user in DB#691
hmassad wants to merge 1 commit into
Gentleman-Programming:mainfrom
hmassad:patch-1

Conversation

@hmassad

@hmassad hmassad commented Aug 3, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes
    • Improved PostgreSQL health checks by using the configured database credentials and name, ensuring more reliable container startup validation.

@coderabbitai

coderabbitai Bot commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1d1161fe-486b-41e7-8d60-7725cc43961a

📥 Commits

Reviewing files that changed from the base of the PR and between 509e676 and 187ebc6.

📒 Files selected for processing (1)
  • docs/engram-cloud/docker-compose.ghcr.yml
📝 Walkthrough

Walkthrough

The PostgreSQL healthcheck in the Docker Compose configuration now reads the username and database from environment variables.

Changes

PostgreSQL healthcheck

Layer / File(s) Summary
Use configured PostgreSQL credentials
docs/engram-cloud/docker-compose.ghcr.yml		 The readiness check uses POSTGRES_USER and POSTGRES_DB instead of hardcoded values.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: gentleman-programming

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing the hardcoded PostgreSQL user from the database healthcheck.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hmassad